Re: [PATCH] lcd: Provide dummy functions if CONFIG_LCD_CLASS_DEVICE is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Четверг, 13 марта 2014, 10:23 +02:00 от Tomi Valkeinen <tomi.valkeinen@xxxxxx>:
> On 13/03/14 09:31, Alexander Shiyan wrote:
> > Provide dummy functions for LCD register()/unregister() if
> > CONFIG_LCD_CLASS_DEVICE is not set.
> 
> Hmm, why do you want to do that? If a driver needs the LCD class, it
> should depend on or select it.

I inspect my recent changes for the imxfb driver.
I use the LCD class for power management and contrast, nevertheless,
if it lack in the kernel this leads to an error.
Yes, we can choose the LCD_CLASS_DEVICE symbol for the imxfb driver,
but at the same time we must choose BACKLIGHT_LCD_SUPPORT.
I do not think it's a good way.
In any case, I would like to revise the patch to use NULL as a result
if there is no support LCD_CLASS_DEVICE in the kernel.
Additionally, I have a plan to convert "menuconfig" entry for
BACKLIGHT_LCD_SUPPORT to the "menu".
OK?

---
��.n��������+%������w��{.n�����{����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux