On 12/16/2013 05:52 AM, Jingoo Han wrote: > On Saturday, December 14, 2013 3:40 AM, Levente Kurusa wrote: >> >> Currently we kfree the container of the device which failed to register. >> This is wrong as the last reference is not given up with a put_device >> call. Also, now that we have put_device() callen, we no longer need >> the kfree as the new_ld->dev.release function will take care of kfreeing >> the associated memory. >> >> Signed-off-by: Levente Kurusa <levex@xxxxxxxxx> > > (+cc Andrew Morton) > > Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > It looks good. > According to the comment of device_register, put_device() > should be used, instead of directly freeing. Indeed, this is also mostly explained in [0/4]. Thanks for the Ack! > [...] > > Levente Kurusa, > By the way, don't send the same mails three times, without any > reason. It is the waste of traffic. :-( > Yea, sorry about that I messed up my git's smtp config and hence most of the messages bounced off. It didn't even reach LKML. Sorry once more. -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
