On Sun, Oct 13, 2013 at 11:22 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > Hi, > > On 12/10/13 01:00, Alexei Starovoitov wrote: >> commit 50e244cc79 >> "fb: rework locking to fix lock ordering on takeover" >> >> fixed the locking, but in one place the console_lock() and lock_fb_info() >> seem to be in the wrong order vs the rest > > The order seems to be lock_fb_info(), console_lock() everywhere. Your > change makes it the other way in one function, so I don't understand how > that could be a correct fix... > > I wonder if you're seeing the same issue as John Tapsell in "fbcon: fix > deadlock in fbcon_generic_blank()"? yes. It is the same issue. console_callback() grabs the console_lock and eventually calls fbcon_blank(). So yes both mine and John's approach needs more work. I guess it's too painful to change lock_fb_info/console_lock order through out fb code... Have to live with workaround for now... -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
