On 30/08/13 13:41, Chen Gang wrote: > On 08/30/2013 06:19 PM, Tomi Valkeinen wrote: >> Here's some old discussion about BUG: >> >> http://yarchive.net/comp/linux/BUG.html >> > > Yeah, if it is not a real bug (can handle it), we should not use BUG(), > but when we are sure it is a kernel bug, and the kernel will continue > blindly, we need use BUG() to stop it. > > Just like the Linus Torvalds said in the link which you provide: > > "Rule of thumb: BUG() is only good for something that never happens and > that we really have no other option for (ie state is so corrupt that > continuing is deadly)". I guess this is where we disagree. I don't see having a corrupt bpp value in a fb driver's internal function as "so corrupt that continuing is deadly". Anyway, if you insist on the BUG(), I'll leave this patch to Jean-Christophe. I'm only taking small-ish patches that have no open issues or disagreements. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
