RE: [PATCH v2 10/24] video: da8xx-fb: fb_set_par support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >
> > +static int da8xxfb_set_par(struct fb_info *info) {
> > +	struct da8xx_fb_par *par = info->par;
> > +	int ret;
> > +	bool raster = da8xx_fb_is_raster_enabled();
> > +
> > +	if (raster)
> > +		lcd_disable_raster(true);
> > +	else
> > +		lcd_disable_raster(false);
> 
> This looks odd. If raster is enabled, you disable it. And if raster is disabled,
> you disable it.

I corrected this one in patch 0011 - I agree this code is very confusing.

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux