Hi Jingoo, On Tue, Jul 16, 2013 at 11:04:09AM +0900, Jingoo Han wrote: > On Tuesday, July 16, 2013 12:27 AM, Maxime Ripard wrote: > > > > From: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> > > > > Add support for the Himax HX8369 controller as it is quite similar to the > > hx8357. > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > > Hi Maxime Ripard, > > I reviewed this patch with Himax HX8369 datasheet. > I cannot find any problems. It looks good. > > However, if possible, please add comment on huge delays such as > msleep(120), msleep(100), etc. Right. I'll send a follow-up patch if this is merged right away, or merge the comments in the next iteration of the patches. > Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Thanks for taking the time to review this! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
