On Tue, 2013-07-16 at 09:49 +0900, Jingoo Han wrote: > On Tuesday, July 16, 2013 12:27 AM, Maxime Ripard wrote: > > + > > + ret = devm_gpio_request_one(&spi->dev, lcd->im_pins[i], > > + GPIOF_OUT_INIT_LOW, "im_pins"); > > This makes a checkpatch warning such as 'WARNING: line over 80 characters'. > How about the following? > > ret = devm_gpio_request_one(&spi->dev, lcd->im_pins[i], > GPIOF_OUT_INIT_LOW, "im_pins"); IIRC, some maintainers gripe (davem?) when they see such alignment, preferring the original arg below arg alignment vs strict 80 column. -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html