On 25/06/13 17:22, Darren Etheridge wrote: > From: Manjunathappa, Prakash <prakash.pm@xxxxxx> > > Set only LCD_V2_TFT_24BPP_MODE bit for 24bpp and LCD_V2_TFT_24BPP_UNPACK > bit along with LCD_V2_TFT_24BPP_MODE for 32bpp configuration. > > Patch is tested on am335x-evm for 24bpp and da850-evm for 16bpp > configurations. > > Signed-off-by: Manjunathappa, Prakash <prakash.pm@xxxxxx> > Signed-off-by: Afzal Mohammed <afzal@xxxxxx> > Signed-off-by: Darren Etheridge <detheridge@xxxxxx> > --- > drivers/video/da8xx-fb.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c > index 35a33ca..7f92f37 100644 > --- a/drivers/video/da8xx-fb.c > +++ b/drivers/video/da8xx-fb.c > @@ -550,10 +550,10 @@ static int lcd_cfg_frame_buffer(struct da8xx_fb_par *par, u32 width, u32 height, > case 4: > case 16: > break; > - case 24: > - reg |= LCD_V2_TFT_24BPP_MODE; > case 32: > reg |= LCD_V2_TFT_24BPP_UNPACK; > + case 24: > + reg |= LCD_V2_TFT_24BPP_MODE; > break; > I'd suggest not to use fall-through here. It just makes the code more difficult to read and more error prone. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
