On Mon, Jun 24, 2013 at 2:45 AM, jett zhou <jett.zhou@xxxxxxxxx> wrote: > Sorry that the comments of the patch is not so clear. > As you might know,We can set two rbswap setting, one is based on > pix_fmt to set into DMA input part, the other is to configured in the output > interface part. > This patch include below change and enhancement: > 1) The input format which support rbswap is based RGB format, YUV > series did not support now. So you can see the patch will change the rbswap > value based on specific RGB format,eg. RGB will set rbswap = 1, BGR will not > set it. What if I'm working with a display that doesn't need or want RB swapping? Lets say I am working with format PIXFMT_RGB565, and running your patch. dmafetch_set_fmt() gets called, and fmt_to_reg() sets rbswap to 1. This means that dmafetch_set_fmt() writes a '1' into the appropriate RB-swapping bit in the LCD_PN_CTRL0 register, and this triggers the "DMA input" swapping that you mentioned. But I never asked for RB swapping... > This part setting is controlled in driver internally, will not > depend on platform configure(link_config) any more. Your patch seems to depend very clearly on link_config. > 2) The output part of rbswap is depend on link_config which is > defined in specific platfrom. > It will setting bit27:24 of 0x01DC register, eg. DSI output > interface can be controlled by this. I don't think you should add more disorganised/undocumented (ab)use of this magic link_config variable. You should create new, dedicated, documented fields. Your comment above suggests that this RB-swapping behaviour is something that is imposed by the output device. In which case, this should be a configuration parameter on the panel, not on the path structure. > TTC_dkb does not support dsi, the link_config is no used anymore. Then you should fix up ttc_dkb before submitting this patch. Thanks Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
