On Mon, Jun 10, 2013 at 9:53 AM, Jett.Zhou <jtzhou@xxxxxxxxxxx> wrote: > From: Jing Xiang <jxiang@xxxxxxxxxxx> > > Add new func mmpfb_set_win to make code clean, it will calculate pitch > value when fb set win in mmpfb_set_win. It looks like a good idea to create a function for setting window parameters from fb info, but this patch also starts to write into the pitch[] fields which are not used anywhere. You should rework these patches so that the pitch field is introduced, set, and consumed all in the same patch. The commit message for the patch that added pitch[] seems to suggest that pitch[1] and pitch[2] are used for YUV formats. But in the code posted here, they will not be used for PIXFMT_YUYV, PIXFMT_UYVY, etc. Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
