On 07/06/13 09:46, Archit Taneja wrote: >> @@ -384,6 +424,10 @@ int omap_dss_register_driver(struct >> omap_dss_driver *dssdriver) >> omapdss_default_get_recommended_bpp; >> if (dssdriver->get_timings == NULL) >> dssdriver->get_timings = omapdss_default_get_timings; >> + if (dssdriver->connect == NULL) >> + dssdriver->connect = omapdss_default_connect; >> + if (dssdriver->disconnect == NULL) >> + dssdriver->disconnect = omapdss_default_disconnect; > > I was wondering if these should be apis rather than driver ops. One > advantage of having them as functions used by omapfb/omapdrm would be > that a panel driver wouldn't override the default_connect/disconnect ops. > > Even though they are named omapdss_default_connect/disconnect, I don't > think there is another option by which a panel driver may chose to > connect to omapdss outputs, right? Those "default" functions are used only for the old panel drivers, and are removed when the old drivers are not needed anymore. They allow us to add the connect support without modifying the old drivers. The new drivers may do other stuff in connect/disconnect. For example, see panel-dsicm.c. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
