2013/5/16, Jingoo Han <jg1.han@xxxxxxxxxxx>: > It makes build warning as below: > > drivers/video/mxsfb.c:887:13: warning: 'host' is used uninitialized in this > function [-Wuninitialized] > drivers/video/mxsfb.c:965:21: warning: 'fb_info' may be used uninitialized > in this function [-Wuninitialized] > > It breaks the assignment. > host = to_imxfb_host(fb_info); > > Also, 'goto fb_release;' is not good. > Please use ' return PTR_ERR(host->base);' as below: > + host->base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(host->base)) > + return PTR_ERR(host->base); > > > Best regards, > Jingoo Han Thank's for reviewing, I'll look at and resend. Laurent, -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html