On 15:13 Mon 15 Apr , Eric Bénard wrote: > Hi, > > Le Mon, 15 Apr 2013 14:43:21 +0200, > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> a écrit : > > > On 16:31 Sun 14 Apr , Markus Pargmann wrote: > > > On Mon, Apr 08, 2013 at 09:57:42AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > On 12:31 Fri 05 Apr , Markus Pargmann wrote: > > > > > Add devicetree support for imx framebuffer driver. It uses the generic > > > > > display bindings and helper functions. > > > > > > > > > > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx> > > > > > Cc: Fabio Estevam <festevam@xxxxxxxxx> > > > > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > > > > > --- > > > > > .../devicetree/bindings/video/fsl,imx-fb.txt | 49 ++++++ > > > > > drivers/video/imxfb.c | 192 +++++++++++++++++---- > > > > > 2 files changed, 207 insertions(+), 34 deletions(-) > > > > > create mode 100644 Documentation/devicetree/bindings/video/fsl,imx-fb.txt > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > > > > > new file mode 100644 > > > > > index 0000000..bde9c77 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > > > > > @@ -0,0 +1,49 @@ > > > > > +Freescale imx21 Framebuffer > > > > > + > > > > > +This framebuffer driver supports devices imx1, imx21, imx25, and imx27. > > > > > + > > > > > +Required properties: > > > > > +- compatible : "fsl,<chip>-fb", chip should be imx1 or imx21 > > > > > +- reg : Should contain 1 register ranges(address and length) > > > > > +- interrupts : One interrupt of the fb dev > > > > > + > > > > > +Required nodes: > > > > > +- display: Phandle to a display node as described in > > > > > + Documentation/devicetree/bindings/video/display-timing.txt > > > > > + Additional, the display node has to define properties: > > > > > + - fsl,bpp: Bits per pixel > > > > > + - fsl,pcr: LCDC PCR value > > > > > + > > > > > +Optional properties: > > > > > +- dmacr-eukrea: Should be set for eukrea boards. > > > > why ? > > > > > > Because eukrea boards have a different dmacr then all other boards using > > > imxfb. The dmacr address is hardcoded as defaults in the code. I could > > > also search for the board name in the DT, but there are no eukrea boards > > > with DT at the moment, so I thought a bool property may be better for > > > the moment. > > so no if an other board come will have an other property no > > > > add an optionnal option to pass the dmacr > > I didn't follow the thread but dmacr is not specific to our boards : > $ grep -rn dmacr arch/arm/mach-imx/ > arch/arm/mach-imx/mach-mx27_3ds.c:446: .dmacr = 0x00020010, > arch/arm/mach-imx/mach-mx21ads.c:231: .dmacr = 0x00020008, > arch/arm/mach-imx/mach-mxt_td60.c:210: .dmacr = 0x00020010, > arch/arm/mach-imx/eukrea_mbimx27-baseboard.c:192: .dmacr = 0x00040060, > arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c:165: .dmacr = 0x00040060, > arch/arm/mach-imx/mach-mx27ads.c:241: .dmacr = 0x00020010, > arch/arm/mach-imx/mach-pca100.c:351: .dmacr = 0x00020010, > arch/arm/mach-imx/pcm970-baseboard.c:185: .dmacr = 0x00020010, > arch/arm/mach-imx/mach-mx25_3ds.c:173: .dmacr = 0x00020010, with this it even more clear nack on the dmacr-eukrea property use an optional property where we can specify the value to use Best Regsrds, J. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
