On Sat, Mar 16, 2013 at 7:06 PM, Marek Vasut <marex@xxxxxxx> wrote: > The issue fixed by this patch manifests only then using X11 > with mxsfb driver. The X11 will display either shifted image > or otherwise distorted image on the LCD. > > The problem is that the X11 tries to reconfigure the framebuffer > and along the way call fb_ops.fb_set_par() with it's configuration > values. The field of particular interest is fb_info->var.sync which > contains non-standard values if configured by kernel. These are > FB_SYNC_DATA_ENABLE_HIGH_ACT and FB_SYNC_DOTCLK_FAILING_ACT defined > in include/linux/mxsfb.h . The driver interprets those and configures > the LCD controller accordingly. Yet X11 only has access to standard > values for this field defined in include/uapi/linux/fb.h and thus > omits these special values. This results in distorted image on the > LCD. > > This patch moves these non-standard values into new field of the > mxsfb_platform_data structure so the driver can in turn check this > field instead of the video mode field for these specific portions. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: Fabio Estevam <fabio.estavem@xxxxxxxxxxxxx> > Cc: Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx> > Cc: Linux FBDEV <linux-fbdev@xxxxxxxxxxxxxxx> > Cc: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx> > Cc: Sascha Hauer <kernel@xxxxxxxxxxxxxx> > Cc: Shawn Guo <shawn.guo@xxxxxxxxxx> This fixes the X11 offset issue on my mx28evk, thanks! Tested-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
