On Thu, 17 Jan 2013 16:23:43 +0800 Zhou Zhu <zzhu3@xxxxxxxxxxx> wrote: > From: Guoqing Li <ligq@xxxxxxxxxxx> > > Marvell mmp series display controller support in mmpdisp subsystem. > This driver focus on implementation of hardware operations of path/ovly, > which is defined in mmp display subsystem interface. > This driver registers all pathes to mmp display framework. > > ... > > +#define ovly_is_vid(ovly) (ovly->dmafetch_id % 2) > +#define path_to_path_plat(path) \ > + ((struct mmphw_path_plat *)path->plat_data) > +#define ovly_to_ctrl(ovly) \ > + (path_to_ctrl(ovly->path)) > +#define path_to_ctrl(path) \ > + (path_to_path_plat(path)->ctrl) > +#define ctrl_regs(path) \ > + (path_to_ctrl(path)->reg_base) These could be implemented in C rather than in CPP. The result would be improved typechecking and improved readability. > > ... > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html