Hello, Thanks :) On Tue, Jan 1, 2013 at 7:44 PM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > On Tuesday, January 01, 2013 6:05 AM, Devendra Naga wrote >> Hello, >> >> while reading through the backlight_register_device function, there > > backlight_register_device -> backlight_device_register > i am sorry i would have really written correctly, >> seems to be a problem if the new object name is null, the pr_debug >> print goes and dereferences a null pointer causing an oops, >> >> the print should be removed or the check must be placed to ensure that >> name is not null, > > Hi, > > If name is null in backlight_device_register(), > pr_debug() will work properly and won't cause an oops. > so if i understand the code pr_debug code, i see a printk macro assignment, is it something like printk or a wrapper macro around printk are making sure that the strings are non null ? i am sorry to ask this as i dont have proper tags in vim ubuntu, its not allowing me to a tag list when i do in fedora :(, > However, dev_set_name() will cause oops, instead of pr_debug(). > In this case, NULL check would be better. > the documentation of the backlight_device_register says that "name must be same as the name of the respected frame buffer device", but do we really add a check for the null to do dev_set_name? or fail the registering ? > > Best regards, > Jingoo Han > >> >> any ideas? >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
