Re: [PATCH v3] video: Versatile Express DVI output driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 19 November 2012, Pawel Moll wrote:
> I've asked the framebuffer people 3 times about this but got no comment
> whatsoever:
> 
> https://patchwork.kernel.org/patch/1473091/
> https://patchwork.kernel.org/patch/1601781/
> 
> so I assume there is no problem with merging this code ;-) Therefore,
> would you be so kind to pull this single patch? Without it the 3.8
> kernel will not be able to show anything on VE's display...

Hi Pawel,

I have two comments for the patch that need to be fixed:

* vexpress_dvi_fb_select uses the 'fb' argument as an index into
  the registered_fb array, but does not check for overflow against
  FB_MAX. I think you need to use get_fb_info().

* There is no documentation for the newly introduced sysfs interface.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux