On 2012-10-29 09:12, Archit Taneja wrote: > Hi, > > On Wednesday 24 October 2012 02:59 PM, Tomi Valkeinen wrote: >> The dispc error handler tries to "fix" issues by disabling and enabling >> panel. This is problematic, as we're trying to remove the dependency >> from omapdss to the omap_dss_devices. It's also racy, and doesn't really >> fix anything. >> >> This patch removes the use of omap_dss_device from the error handler, >> and just disables and enables the associated overlay manager. This >> should produce similar results as the previous solution, without using >> dssdev. > > Calling APPLY functions from the DISPC driver seems a bit incorrect. > Instead of disabling/enabling the panel, can't we disable/enable the > manger by just using DISPC funcs? I agree, but if we don't call apply functions, we're bypassing the locks/etc from apply, and we could end up messing up what apply.c thinks is going on. With my omapdss+omapdrm compatibility patch series I'm moving the error handler to the apply mechanism, so it becomes a bit saner. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
