On 2012-10-17 17:38, Archit Taneja wrote:
> Hi,
>
> On Wednesday 17 October 2012 04:50 PM, Tomi Valkeinen wrote:
>> - if (r)
>> - DSSERR("failed to register FRAMEDONE isr\n");
>> + /* if we couldn't register for framedone, just sleep and exit */
>> + if (r) {
>> + msleep(200);
>
> We sleep for 200 ms if we fail to register for framedone. But we just
> wait for 100ms for FRAMEDONE to occur. It seems a bit incorrect, both
> should be kept the same, shouldn't they?
They are just arbitrary numbers, but you're right, it makes more sense
to have same numbers for both.
>> - r = omap_dispc_register_isr(dispc_disable_isr,
>> &frame_done_completion,
>> + r = omap_dispc_register_isr(dispc_mgr_disable_isr, &framedone_compl,
>> irq_mask);
>> if (r)
>> DSSERR("failed to register %x isr\n", irq_mask);
>
> We should probably sleep here too as we did for LCD above.
Yep, good point. I'll add that.
Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
