On Thu, 2012-08-16 at 13:06 +0530, Archit Taneja wrote: > The DSI driver currently relies on the omap_dss_device struct to receive the > video mode timings requested by the panel driver. This makes the DSI interface > driver dependent on the omap_dss_device struct. > > Make the DSI driver data maintain it's own video mode timings field. The panel > driver is expected to call omapdss_dsi_set_videomode_timings() to configure the > video mode timings before the interface is enabled. The function takes in a > void pointer rather than a pointer to omap_dss_dsi_videomode_timings struct. > This is because this function will finally be an output op shared across > different outputs to set custom or private timings. I don't think the function should take a void * in any case. If we want to share the function, it should take a struct that perhaps contains an union of rfbi and dsi timings. But I'm not sure if there's any benefit for that... So do you see us having just one set_timings, which would take either the normal video timings, rfbi timings or dsi timings? Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
