On Tuesday 07 August 2012 02:21 PM, Felipe Balbi wrote: > On Tue, Aug 07, 2012 at 01:58:17PM +0530, Chandrabhanu Mahapatra wrote: >> OMAP4 checks are removed from VENC to provide it a cleaner interface. These >> checks were introduced by patches "HACK: OMAP: DSS2: VENC: disable VENC on OMAP4 >> to prevent crash" (ba02fa37de) by Tomi Valkeinen <tomi.valkeinen@xxxxxx> and >> "OMAPDSS: VENC: fix NULL pointer dereference in DSS2 VENC sysfs debug attr on >> OMAP4" (cc1d3e032d) by Danny Kukawka <danny.kukawka@xxxxxxxxx> to prevent VENC >> from crashing OMAP4 kernel. An alternative approach is used to do the same in >> later patches. > in later patches ? This means you're causing a regression here. Just > swap the patches around to avoid it. > Hi! Yes I do agree with you. But as VENC is disabled on omap4, the basic idea here was to remove unnecessary cpu_is checks and achieve the same through a better approach. -- Chandrabhanu Mahapatra Texas Instruments India Pvt. Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
