On Tue, Jul 31, 2012 at 3:57 PM, Mike Frysinger <vapier@xxxxxxxxxx> wrote: > On Tue, Jul 31, 2012 at 9:54 AM, Damien Cassou <damien.cassou@xxxxxxx> wrote: >> The various devm_ functions allocate memory that is released when a driver >> detaches. This patch uses these functions for data that is allocated in >> the probe function of a platform device and is only freed in the remove >> function. > > Acked-by: Mike Frysinger <vapier@xxxxxxxxxx> This whole patch is invalid, because of this part: - info->fb_buffer = dma_alloc_coherent(NULL, fbinfo->fix.smem_len + - ACTIVE_VIDEO_MEM_OFFSET, - &info->dma_handle, GFP_KERNEL); + info->fb_buffer = dmam_alloc_coherent(&pdev->dev, NULL, + fbinfo->fix.smem_len + + ACTIVE_VIDEO_MEM_OFFSET, + &info->dma_handle, GFP_KERNEL); dmam_alloc_coherent() is called with 5 arguments but only accepts 4. Please ignore this whole patch altogether. I am sorry about that. -- Damien Cassou http://damiencassou.seasidehosting.st "Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
