>>>>> "Prakash" == Manjunathappa, Prakash <prakash.pm@xxxxxx> writes: Hi, >> Personally I don't like, mix of "u32" and "unsigned int" declaration. >> Prakash> "unsigned int" is not guaranteed to be 32bit, may be "unsigned Prakash> long" is better choice. On the platforms where da8xx-fb is used it is. >> > unsigned int palette_sz; >> > unsigned int pxl_clk; >> > int blank; >> > @@ -546,6 +546,8 @@ static int lcd_cfg_frame_buffer(struct da8xx_fb_par *par, u32 width, u32 height, >> > return 0; >> > } >> > >> > + >> > +#define CNVT_TOHW(val, width) ((((val)<<(width))+0x7FFF-(val))>>16) >> >> Did you run checkpatch.pl on this patch? >> Prakash> Yes, checkpatch.pl did not complain anything on this line. I Prakash> will add space around binary operators. An inline function would be nicer. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
