On 05/03/2012 12:34 AM, H Hartley Sweeten wrote: > Functions not referenced outside of a source file should be marked > static to prevent them from being exposed globally. > > Quiets the sparse warnings: > > warning: symbol 'mb862xx_i2c_stop' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> > Cc: Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> > Cc: Anatolij Gustschin <agust@xxxxxxx> Applied. Thanks, Florian Tobias Schandinat > > --- > > diff --git a/drivers/video/mb862xx/mb862xx-i2c.c b/drivers/video/mb862xx/mb862xx-i2c.c > index 273769b..c87e17a 100644 > --- a/drivers/video/mb862xx/mb862xx-i2c.c > +++ b/drivers/video/mb862xx/mb862xx-i2c.c > @@ -68,7 +68,7 @@ static int mb862xx_i2c_read_byte(struct i2c_adapter *adap, u8 *byte, int last) > return 1; > } > > -void mb862xx_i2c_stop(struct i2c_adapter *adap) > +static void mb862xx_i2c_stop(struct i2c_adapter *adap) > { > struct mb862xxfb_par *par = adap->algo_data; > > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html