Hi Peter, On 05/03/2012 09:40 PM, Peter Hüwe wrote: > Hi Florian, > >> As far as I can see it should be possible to keep the array in >> sis_main.c and just delete it in the header files, shouldn't it? I'd >> prefer to do it this way. > > Yes it is absolutely possible to leave it in sis_main.c and remove it from the > header files. I already thought about this when creating the patch, but > decided against it, as the 17*5 = 85 bytes are allocated on the stack, while > they nicely can be put in the .devinit.rodata section ;) You can still mark it as __devinitconst, I just wanted to have the array inside a C file, not a header. If you agree with this, I'll change your new patch that way. > > With the patch: > 344072 sis_main.o > 1200950 sisfb.o > 1217491 sisfb.ko > > vs without the patch and removing it only from the header: > 344176 sis_main.o > 1201056 sisfb.o > 1217597 sisfb.ko -> ~100bytes more in the final module. > > However I'm fine with this and will remove it from the header and squash this > together with the > "video/sis: Remove unused structs SiS_SDRDRAM_TYPE/SiS_DDRDRAM_TYPE" > I also sent to you. Thanks, Florian Tobias Schandinat -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
