Re: [PATCH V2] i.MX28: Shut down the LCD controller to avoid BootROM sampling bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/19/2012 06:31 PM, Marek Vasut wrote:
> From: Marek Vasut <marek.vasut@xxxxxxxxx>
> 
> If there's some traffic on the LCD controller pads, the BootROM has trouble with
> sampling the bootmode from these pads. The BootROM usually ends in a loop.
> 
> Signed-off-by: Marek Vasut <marek.vasut@xxxxxxxxx>
> Cc: Chen Peter-B29397 <B29397@xxxxxxxxxxxxx>
> Cc: Detlev Zundel <dzu@xxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@xxxxxx>
> Cc: Li Frank-B20596 <B20596@xxxxxxxxxxxxx>
> Cc: Lin Tony-B19295 <B19295@xxxxxxxxxxxxx>
> Cc: Linux FBDEV <linux-fbdev@xxxxxxxxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Shawn Guo <shawn.guo@xxxxxxxxxxxxx>
> Cc: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Cc: Stefano Babic <sbabic@xxxxxxx>
> Cc: Subodh Nijsure <snijsure@xxxxxxxxxxxx>
> Cc: Tony Lin <tony.lin@xxxxxxxxxxxxx>
> Cc: Wolfgang Denk <wd@xxxxxxx>
> Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Acked-by: Wolfgang Denk <wd@xxxxxxx>
> Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> Tested-by: Wolfgang Denk <wd@xxxxxxx>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/mxsfb.c |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> V2: Make shutdown() call static
> 
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 4a89f88..dcf29bf 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -880,6 +880,18 @@ static int __devexit mxsfb_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static void mxsfb_shutdown(struct platform_device *pdev)
> +{
> +	struct fb_info *fb_info = platform_get_drvdata(pdev);
> +	struct mxsfb_info *host = to_imxfb_host(fb_info);
> +
> +	/*
> +	 * Force stop the LCD controller as keeping it running during reboot
> +	 * might interfere with the BootROM's boot mode pads sampling.
> +	 */
> +	writel(CTRL_RUN, host->base + LCDC_CTRL + REG_CLR);
> +}
> +
>  static struct platform_device_id mxsfb_devtype[] = {
>  	{
>  		.name = "imx23-fb",
> @@ -896,6 +908,7 @@ MODULE_DEVICE_TABLE(platform, mxsfb_devtype);
>  static struct platform_driver mxsfb_driver = {
>  	.probe = mxsfb_probe,
>  	.remove = __devexit_p(mxsfb_remove),
> +	.shutdown = mxsfb_shutdown,
>  	.id_table = mxsfb_devtype,
>  	.driver = {
>  		   .name = DRIVER_NAME,

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux