On 01/30/2012 10:00 PM, Danny Kukawka wrote:
> Fix several -Wuninitialized compiler warnings by changing the
> order of getting modedb in riva_update_default_var() to set
> first the fallback and then the prefered timing.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@xxxxxxxxx>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/riva/fbdev.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/riva/fbdev.c b/drivers/video/riva/fbdev.c
> index 2f58cf9..90df1a6 100644
> --- a/drivers/video/riva/fbdev.c
> +++ b/drivers/video/riva/fbdev.c
> @@ -1816,6 +1816,8 @@ static void __devinit riva_update_default_var(struct fb_var_screeninfo *var,
> specs->modedb, specs->modedb_len,
> NULL, 8);
> } else if (specs->modedb != NULL) {
> + /* get first mode in database as fallback */
> + modedb = specs->modedb[0];
> /* get preferred timing */
> if (info->monspecs.misc & FB_MISC_1ST_DETAIL) {
> int i;
> @@ -1826,9 +1828,6 @@ static void __devinit riva_update_default_var(struct fb_var_screeninfo *var,
> break;
> }
> }
> - } else {
> - /* otherwise, get first mode in database */
> - modedb = specs->modedb[0];
> }
> var->bits_per_pixel = 8;
> riva_update_var(var, &modedb);
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
