Hi Laurent Cc Magnus, Guennadi Thank you for checking patch > > + void (*set_dcs)(int handle, > > + int (*mipi_dcs)(int handle, u8 cmd), > > + int (*mipi_dcs_param)(int handle, u8 cmd, u8 param)); > > I don't think this is a good idea. First of all, we should reduce the number > of board code callbacks to make transition to the device tree easier. Then, > passing two functions to board code to read and write any device register > without the driver having any knowledge about that is a clear violation of the > device model, and will result in problems sooner or later. > > What MIPI settings do platforms need to modify ? Can those settings be > expressed as data in the sh_mipi_dsi_info structure instead ? Hmm... now I'm in dilemma. Actually this is v2 patch for mipi display. (v1 patch was dropped since merge window issue) The v1 patch was data-table style for mipi display initialization. (if platform had init data-table, driver used it) But someone reviewed it and teach me that it is not-good idea. So, I created this style in v2. Now platform needs "backlight ON" and "memory write ON" command, but I could not find these command on include/video/mipi_display.h. So, I thought it is platform specific command. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
