On 10/05/2011 09:59 AM, Alexander Stein : > If used with negative polarity the PWM unit cannot be disabled. This would > result in a full contrast screen. > Instead let the PWM unit enabled using 0x0 as compare value which darkens > the display. > In result no power saving is possible if inverted contrast polarity > is used. Ok, this patch looks correct. > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx> Florian, you can propagate this one upstream. Thanks you, best regards, > --- > drivers/video/atmel_lcdfb.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c > index 816d528..2bd75b5 100644 > --- a/drivers/video/atmel_lcdfb.c > +++ b/drivers/video/atmel_lcdfb.c > @@ -96,8 +96,11 @@ static int atmel_bl_update_status(struct backlight_device *bl) > brightness = 0; > > lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_VAL, brightness); > - lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, > + if (contrast_ctr & ATMEL_LCDC_POL_POSITIVE) > + lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, > brightness ? contrast_ctr : 0); > + else > + lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, contrast_ctr); > > bl->props.fb_blank = bl->props.power = sinfo->bl_power = power; > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
