On Thu, 29 Dec 2011 18:20:38 +0000 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > Should be no functional changes, mainly a reorganisation to support > future work. > > ... > > -#define pwm_backlight_suspend NULL > -#define pwm_backlight_resume NULL > +#define pwm_backlight_pm_ops NULL > #endif > > static struct platform_driver pwm_backlight_driver = { > .driver = { > .name = "pwm-backlight", > .owner = THIS_MODULE, > + .pm = &pwm_backlight_pm_ops, This: .pm = &NULL, will not compile. Please review and test: From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: backlight-convert-pwm_bl-to-dev_pm_ops-fix Fix CONFIG_PM=n build Cc: Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> Cc: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> Cc: Richard Purdie <rpurdie@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/video/backlight/pwm_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/video/backlight/pwm_bl.c~backlight-convert-pwm_bl-to-dev_pm_ops-fix drivers/video/backlight/pwm_bl.c --- a/drivers/video/backlight/pwm_bl.c~backlight-convert-pwm_bl-to-dev_pm_ops-fix +++ a/drivers/video/backlight/pwm_bl.c @@ -194,15 +194,15 @@ static int pwm_backlight_resume(struct d static SIMPLE_DEV_PM_OPS(pwm_backlight_pm_ops, pwm_backlight_suspend, pwm_backlight_resume); -#else -#define pwm_backlight_pm_ops NULL #endif static struct platform_driver pwm_backlight_driver = { .driver = { .name = "pwm-backlight", .owner = THIS_MODULE, +#ifdef CONFIG_PM .pm = &pwm_backlight_pm_ops, +#endif }, .probe = pwm_backlight_probe, .remove = pwm_backlight_remove, _ -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html