On Tue, 13 Dec 2011, Laurent Pinchart wrote: > Store the active format in the channel structure, and use it instead of > parsing info->var all over the place when the format is needed. Right, this is what I was wondering about, while looking at the previous patch:-) But: > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/video/sh_mobile_lcdcfb.c | 21 ++++++++++----------- > drivers/video/sh_mobile_lcdcfb.h | 4 +++- > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c > index c6b6b9d..9829e01 100644 > --- a/drivers/video/sh_mobile_lcdcfb.c > +++ b/drivers/video/sh_mobile_lcdcfb.c [snip] > @@ -1350,6 +1345,8 @@ static int sh_mobile_set_par(struct fb_info *info) > info->fix.line_length = info->var.xres > * info->var.bits_per_pixel / 8; > > + ch->format = sh_mobile_format_info(sh_mobile_format_fourcc(&info->var)); Cannot this be NULL? As far as I could trace it back, I'm not sure with hotplug bits_per_pixel would be initialised correctly along the lines of sh_mobile_fb_reconfig(). Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
