Re: [PATCH V2] viafb: replace strict_strtoul to kstrto* and check return value

Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> · Mon, 08 Aug 2011 00:10:55 +0000

On 08/07/2011 11:42 PM, stufever@xxxxxxxxx wrote:

diff --git drivers/video/via/viafbdev.c drivers/video/via/viafbdev.c

Um, you did something different this time, causing another (not critical) 
checkpatch warning
WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch

@@ -1325,7 +1328,8 @@ static ssize_t viafb_dfpl_proc_write(struct file *file,
  	if (copy_from_user(&buf[0], buffer, length))
  		return -EFAULT;
  	buf[length - 1] = '\0';	/*Ensure end string */
-	strict_strtoul(&buf[0], 0, (unsigned long *)&reg_val);
+	if (kstrtou8(buf, -1,&reg_val)<  0)

Did you miss my comment about the -1 above last time? Why it is there?

+		return -EINVAL;
  	viafb_write_reg_mask(CR99, VIACR, reg_val, 0x0f);
  	return count;
  }

Thanks,

Florian Tobias Schandinat
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html





