Re: [PATCH] carminefb: Fix module parameters permissions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 08, 2011 at 11:04:38AM +0200, Jean Delvare wrote:
> The third parameter of module_param is supposed to be an octal value.
> The missing leading "0" causes the following:
> 
> $ ls -l /sys/module/carminefb/parameters/
> total 0
> -rw-rwxr-- 1 root root 4096 Jul  8 08:55 fb_displays
> -rw-rwxr-- 1 root root 4096 Jul  8 08:55 fb_mode
> -rw-rwxr-- 1 root root 4096 Jul  8 08:55 fb_mode_str
> 
> After fixing the perm parameter, we get the expected:
> 
> $ ls -l /sys/module/carminefb/parameters/
> total 0
> -r--r--r-- 1 root root 4096 Jul  8 08:56 fb_displays
> -r--r--r-- 1 root root 4096 Jul  8 08:56 fb_mode
> -r--r--r-- 1 root root 4096 Jul  8 08:56 fb_mode_str
> 
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Paul Mundt <lethal@xxxxxxxxxxxx>
> Cc: Sebastian Siewior <bigeasy@xxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx
> ---
>  drivers/video/carminefb.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux