Re: [PATCH] drivers/video/udlfb bind framebuffer to interface.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Bernie Thompson.
> -----Original Message-----
> From: linux-fbdev-owner@xxxxxxxxxxxxxxx [mailto:linux-fbdev-
> owner@xxxxxxxxxxxxxxx] On Behalf Of bernie@xxxxxxxxxxxx
> Sent: Wednesday, July 06, 2011 9:04 AM
> To: linux-fbdev@xxxxxxxxxxxxxxx
> Cc: lethal@xxxxxxxxxxxx; Kay Sievers; Bernie Thompson
> Subject: [PATCH] drivers/video/udlfb bind framebuffer to interface.
> 
> From: Kay Sievers <kay.sievers@xxxxxxxx>
> 
> Udlfb has been binding the framebuffer device to its parent, which
> isn't correct and causes confusion with operations like udev remove.
> 
> Coming plug and play multiseat support is dependent on this fix.
> 
> Signed-off-by: Bernie Thompson <bernie@xxxxxxxxxxxx>
This patch author seems to be Kay Sievers <kay.sievers@xxxxxxxx>.
Should you add Signed-off-by: Kay Sievers <kay.sievers@xxxxxxxx> ?
> ---
>  drivers/video/udlfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
> index 816a4fd..c6584c9 100644
> --- a/drivers/video/udlfb.c
> +++ b/drivers/video/udlfb.c
> @@ -1549,7 +1549,7 @@ static int dlfb_usb_probe(struct usb_interface
> *interface,
>  	/* We don't register a new USB class. Our client interface is fbdev
> */
> 
>  	/* allocates framebuffer driver structure, not framebuffer memory
> */
> -	info = framebuffer_alloc(0, &usbdev->dev);
> +	info = framebuffer_alloc(0, &interface->dev);
>  	if (!info) {
>  		retval = -ENOMEM;
>  		pr_err("framebuffer_alloc failed\n");
> --
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

ÿ淸º{.nÇ+돴윯돪†+%듚ÿ깁負¥Šwÿº{.nÇ+돴¥Š{깰鍼zÿâ왲^n‡r⊆¦zË곷h솳鈺Ú&{àz요z받쀺+€Ê+zf"·hš닱~넮녬iÿÿï곴ÿ묎çz_溫æj:+v돣þ)山øm



[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux