Re: [PATCH] video: Add GRVGA framebuffer device driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 15, 2011 at 10:56, Kristoffer Glembo <kristoffer@xxxxxxxxxxx> wrote:
> This patch adds support for the GRVGA framebuffer IP core from Aeroflex Gaisler.
> The device is used in LEON SPARCV8 based System on Chips. Documentation can
> be found here: www.gaisler.com/products/grlib/grip.pdf.
>
> Signed-off-by: Kristoffer Glembo <kristoffer@xxxxxxxxxxx>
> ---
> Âdrivers/video/Kconfig Â| Â 10 +
> Âdrivers/video/Makefile | Â Â1 +
> Âdrivers/video/grvga.c Â| Â559 ++++++++++++++++++++++++++++++++++++++++++++++++
> Â3 files changed, 570 insertions(+), 0 deletions(-)
> Âcreate mode 100644 drivers/video/grvga.c
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 549b960..18ee201 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -259,6 +259,16 @@ config FB_TILEBLITTING
> Âcomment "Frame buffer hardware drivers"
> Â Â Â Âdepends on FB
>
> +config FB_GRVGA
> + Â Â Â tristate "Aeroflex Gaisler framebuffer support"
> + Â Â Â depends on FB && SPARC

At first sight, nothing in this driver seems to be SPARC-specific, so
perhaps this can be relaxed
to e.g. depends on OF_DEVICE?

> + Â Â Â select FB_CFB_FILLRECT
> + Â Â Â select FB_CFB_COPYAREA
> + Â Â Â select FB_CFB_IMAGEBLIT
> + Â Â Â ---help---
> + Â Â Â This enables support for the SVGACTRL framebuffer in the GRLIB IP library from Aeroflex Gaisler.
> +
> +
> Âconfig FB_CIRRUS
> Â Â Â Âtristate "Cirrus Logic support"
> Â Â Â Âdepends on FB && (ZORRO || PCI)

> --- /dev/null
> +++ b/drivers/video/grvga.c

> + Â Â Â dev_info(&dev->dev,
> + Â Â Â Â Â Â Â Â"Aeroflex Gaisler framebuffer device (fb%d), %dx%d-%d, using %luK of video memory @ 0x%x\n",
> + Â Â Â Â Â Â Â Âinfo->node, info->var.xres, info->var.yres, info->var.bits_per_pixel,
> + Â Â Â Â Â Â Â Âgrvga_mem_size >> 10, (unsigned int) info->screen_base);
                                ^^^^^^^^^^^^^^
Please remove the cast and use %p to format the address.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux