Hi Magnus, On 2011/05/27 17:14, Magnus Damm wrote: > Hi Damian, > > On Thu, May 26, 2011 at 6:09 PM, Damian Hobson-Garcia > <dhobsong@xxxxxxxxxx> wrote: >> The ordering of the bytes in the 24 bpp RGB colour mode was >> being set to BGR. >> >> This now matches the values returned in the >> struct fb_var_screeninfo .red, .green, and .blue offsets as well as >> the output format of other blocs, such as the VEU >> >> Signed-off-by: Damian Hobson-Garcia <dhobsong@xxxxxxxxxx> >> --- > > Thanks for your patch. With this change in place, is the fbdev console > still working as expected? > > Also, the byte swap settings in _LDDDSR are ok as-is? Actually, let me look into this a bit more. After thinking about it some more there are one or two more things I want to check on this first. Please ignore this patch for now. I'll resubmit it again once its properly completed. Sorry for the mess. Thanks, Damian -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html