Re: [PATCH 27/29] vt8500lcdfb: use display information in info not in var for panning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/5/26 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>:
> We must not use any information in the passed var besides xoffset,
> yoffset and vmode as otherwise applications might abuse it.

Agreed, thanks for the fix!

> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Alexey Charkov <alchark@xxxxxxxxx>
> ---
> Âdrivers/video/vt8500lcdfb.c | Â Â4 ++--
> Â1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c
> index 0e120d6..c13c246 100644
> --- a/drivers/video/vt8500lcdfb.c
> +++ b/drivers/video/vt8500lcdfb.c
> @@ -210,8 +210,8 @@ static int vt8500lcd_pan_display(struct fb_var_screeninfo *var,
> Â Â Â Âstruct vt8500lcd_info *fbi = to_vt8500lcd_info(info);
>
> Â Â Â Âwritel((1 << 31)
> - Â Â Â Â Â Â Â | (((var->xres_virtual - var->xres) * pixlen / 4) << 20)
> - Â Â Â Â Â Â Â | (off >> 2), fbi->regbase + 0x20);
> + Â Â Â Â Â Â| (((info->var.xres_virtual - info->var.xres) * pixlen / 4) << 20)
> + Â Â Â Â Â Â| (off >> 2), fbi->regbase + 0x20);
> Â Â Â Âreturn 0;
> Â}
>
> --
> 1.7.3.4
>
>

Best regards,
Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux