Hello Grant, Grant Likely wrote: > On Mon, May 2, 2011 at 4:27 PM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: >> On Tue, Mar 22, 2011 at 09:27:29AM +0100, Heiko Schocher wrote: >>> - add commandline options: >>> sm501fb.mode: >>> Specify resolution as "<xres>x<yres>[-<bpp>][@<refresh>]" >>> sm501fb.bpp: >>> Specify bit-per-pixel if not specified mode >>> >>> - Add support for encoding display mode information >>> in the device tree using verbatim EDID block. >>> >>> If the "edid" entry in the "smi,sm501" node is present, >>> the driver will build mode database using EDID data >>> and allow setting the display modes from this database. >>> >>> Signed-off-by: Heiko Schocher <hs@xxxxxxx> >> Merged, thanks. > > This patch causes the following build warning: Hups ... when I posted the patch, it compiled clean ... > MODPOST vmlinux.o > WARNING: vmlinux.o(.text+0x1d5572): Section mismatch in reference from > the function sm501fb_init_fb() to the variable > .devinit.data:sm501_default_mode > The function sm501fb_init_fb() references > the variable __devinitdata sm501_default_mode. > This is often because sm501fb_init_fb lacks a __devinitdata > annotation or the annotation of sm501_default_mode is wrong. > > WARNING: vmlinux.o(.text+0x1d557a): Section mismatch in reference from > the function sm501fb_init_fb() to the variable > .devinit.data:sm501_default_mode > The function sm501fb_init_fb() references > the variable __devinitdata sm501_default_mode. > This is often because sm501fb_init_fb lacks a __devinitdata > annotation or the annotation of sm501_default_mode is wrong. > > I've dropped the __devinitdata declaration in what I committed; can > you investigate and post a fixup patch? Of course, I look ASAP at it, thanks! (Dummy question: where can I find your tree?) bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html