Hi Damian, Thanks for your work on this! On Tue, Mar 29, 2011 at 12:35 PM, Damian Hobson-Garcia <dhobsong@xxxxxxxxxx> wrote: > This patch series is based on the fbdev tree. > > This series adds support for read-ahead cache access through the ICBs and > MERAM available on SH devices. The exact ICBs to use are chip specific > and are specified in the platform data. > > Damian Hobson-Garcia (3): > sh_mobile_meram: MERAM framework for LCDC > sh_mobile_meram: Add support for NV24 framebuffers > sh_mobile_meram: MERAM platform data for LCDC I think these patches look very good in general. I have one request and some general comments: Please add Runtime PM support to the MERAM driver. The MSTP113 bit of SMSTPCR1 should be dynamically controlled using pm_runtime_get_sync() and pm_runtime_put_sync(). I also wonder if we can chose to use MERAM dynamically somehow. I know the sh7372 MERAM can be used to back the entire frame buffer memory (controlled by the LRCTRL register, see the MERAM section in the sh7372 data sheet). This fully-backed mode can perhaps be used to save power for regular low-performance operation and/or semi-standby. For low-performance operation I imagine that by using MERAM for frame buffer memory we can put the SDRAM in self-refresh mode and that way enter deep idle modes even though the screen is still operating. The semi-standby would be that the "real" framebuffer is in say 32-bit RGB in SDRAM, but we keep a 8-bit RGB shadow buffer in MERAM and switch to that at the same instant we move from full backlight to low backlight. This is most likely useful only when combined with switching the LCD panel itself to 8-bit mode as well to save bandwidth. Then you have your full-performance mode that I guess is what these patches implement. =) Any ideas/suggestions about the low power LCDC modes? Thanks, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
