On Sun, Dec 12, 2010 at 09:37:38AM +0800, Liu Ying wrote: > Hello, Sascha, > > I have following 3 comments to this patch: > 1) I think DISP1_DATx pins need not be set specially, as they keep the > default register values. We do not want to depend on default register values in the Linux Kernel. > 2) Please define 'MX51_PAD_DI_GP4__IPU_DI2_PIN15' in > arch/arm/plat-mxc/include/mach/iomux-mx51.h, and rename the pin to be > 'MX51_PAD_DI_GP4__DI2_PIN15', as we name it according to the MX51 > iomux reference manual. I'm not sure. Normally it's good practice to code the unit into the name. Otherwise we end up with names like MX51_PAD_xyz__TX which could be the tx pin of just about any unit. > 3) It is better to exchange the following two lines or just remove the > first line: > + gpio_set_value(GPIO_DVI_RESET, 0); > + gpio_direction_output(GPIO_DVI_RESET, 0); ok. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
