Hello Randy, Randy Dunlap wrote: > On Sat, 11 Dec 2010 07:31:15 +0100 Heiko Schocher wrote: > >> - add commandline options: >> sm501.fb_mode: > > sm501.mode: Sorry, type, should be "sm501fb.mode", thanks! >> Specify resolution as "<xres>x<yres>[-<bpp>][@<refresh>]" >> sm501.bpp: Here too, "sm501fb.bpp" >> Specify bit-per-pixel if not specified mode >> >> --- >> >> Documentation/kernel-parameters.txt | 7 + >> Documentation/powerpc/dts-bindings/sm501.txt | 30 +++ >> drivers/mfd/sm501.c | 141 ++++++++------ >> drivers/video/sm501fb.c | 264 +++++++++++++++++--------- >> include/linux/sm501.h | 8 + >> 5 files changed, 299 insertions(+), 151 deletions(-) >> create mode 100644 Documentation/powerpc/dts-bindings/sm501.txt >> >> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt >> index cdd2a6e..6341541 100644 >> --- a/Documentation/kernel-parameters.txt >> +++ b/Documentation/kernel-parameters.txt >> @@ -2301,6 +2301,13 @@ and is between 256 and 4096 characters. It is defined in the file >> merging on their own. >> For more information see Documentation/vm/slub.txt. >> >> + sm501.bpp= SM501 Display driver: >> + Specify bit-per-pixel if not specified mode > > Specifiy bits-per-pixel if not specified by 'mode' > >> + >> + sm501fb.mode= SM501 Display driver: > > Shouldn't that be sm501.mode ? No, the name of the source file is sm501fb.c -> sm501fb is right here. As the sm501 is a multifunction device, the "fb" is more precise here. >> + Specify resolution as >> + "<xres>x<yres>[-<bpp>][@<refresh>]" >> + >> smart2= [HW] >> Format: <io1>[,<io2>[,...,<io8>]] > > > However, I think that these shouldn't be added to Documentation/kernel-parameters.txt > but should be added to the Documentation/fb/ sub-directory either by adding to > Documentation/fb/modedb.txt or by adding a new file Documentation/fb/sm501.txt. Ok, do this. Thanks for the review! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
