Re: [PATCH 1/2] fbdev: bf537-lq035: new Blackfin Sharp LQ035 framebuffer driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 25, 2010 at 04:21:48AM -0500, Mike Frysinger wrote:
> On Thursday, November 25, 2010 03:28:11 Paul Mundt wrote:
> > On Wed, Nov 24, 2010 at 04:33:58AM -0500, Mike Frysinger wrote:
> > > From: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> > > 
> > > For LCDs hooked up to BF537-STAMP boards.
> > > 
> > > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> > > Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>
> > > Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> > > ---
> > > note: these have been posted in the past, but before we got a fbdev
> > > 
> > > 	maintainer, so i'm just reposting them to hopefully get merged
> > 
> > On Wed, Nov 24, 2010 at 04:33:59AM -0500, Mike Frysinger wrote:
> > > From: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> > > 
> > > Driver for ADV7393 add-on card for multiple Blackfin boards.
> > > 
> > > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> > > Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>
> > > Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> > > ---
> > > note: these have been posted in the past, but before we got a fbdev
> > > 
> > > 	maintainer, so i'm just reposting them to hopefully get merged
> > 
> > While I don't really have any strong opinions about these drivers one way
> > or the other, a cursory glance shows that they end up sharing quite a bit
> > of code, along with the existing in-tree blackfin fb drivers. Have you
> > considered trying to abstract things a bit and moving things in to a
> > drivers/video/bfin or the like? Much of the DMA and PPI stuff looks like
> > it could be pretty easily broken out.
> 
> we have thought about it quite a bit, but havent quite gotten an answer that 
> worked without a lot of cruft

Ok. They're pretty limited in scope anyways, so there's not much harm in
adding them as-is. I've queued them up for .38. I would like to see some
effort to get the blackfin drivers tidied up and a bit more consolidated
in the future, before things get too far out of hand, however.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux