On Wed, 10 Nov 2010, Paul Mundt wrote:
> On Tue, Nov 02, 2010 at 11:47:40AM +0100, Guennadi Liakhovetski wrote:
> > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
> > index 38b3c30..943bcff 100644
> > --- a/drivers/video/fbmon.c
> > +++ b/drivers/video/fbmon.c
> > @@ -973,6 +973,45 @@ void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs)
> > DPRINTK("========================================\n");
> > }
> >
> > +const struct fb_videomode cea_modes[] = {
>
> This wants to be in drivers/video/modedb.c nested under
> CONFIG_FB_MODE_HELPERS, you can simply follow the vesa_modes
> example. Given that this can also be modular, you'll need a symbol export
> for cea_modes in addition to a prototype in include/linux/fb.h.
Actually it should have been static, it should only be used in
fb_edid_add_monspecs(). But if we move it to modedb.c, then it certainly
becomes global, but still doesn't have to be exported, modedb.c and
fbmon.c are always linked together. As for CONFIG_FB_MODE_HELPERS - yes,
it is already under it in fbmon.c. But well, yes, in the future these CEA
modes can be used by other code paths, so, moving it to modedb.c might be
more logical, yes, but I wouldn't export it.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
