On Wed, Aug 25, 2010 at 5:00 PM, Ryan Mallon <ryan@xxxxxxxxxxxxxxxx> wrote: >>> Its useful for debugging while developing the driver, but it adds a lot >>> of code. Do you expect the register dumping features to be required once >>> the driver hits mainline? >> >> I expect the driver will hit mainline is several phases. This first >> one. One where HDMI works. One where DSI works. One which has >> rotation. This code is useful for all those phases. > ... >> They still fill different uses. You can't cat a debugfs file from an >> interrupt handler. You can't call dump_regs() from userspace. I'm >> still actively using both. I could see taking one out once >> development on the driver calms down. > > Okay, maybe keep both with a comment stating why the debug is still > there, and that it is scheduled to be removed once the driver is > complete in mainline? OK will do. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
