Re: [patch] fb: handle allocation failure in alloc_apertures()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> If the kzalloc() fails we should return NULL.  All the places that call
> alloc_apertures() check for this already.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

Acked-by: James Simmons <jsimmons@xxxxxxxxxxxxx>
 
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index 8e5a9df..e7445df 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -873,6 +873,8 @@ struct fb_info {
>  static inline struct apertures_struct *alloc_apertures(unsigned int max_num) {
>  	struct apertures_struct *a = kzalloc(sizeof(struct apertures_struct)
>  			+ max_num * sizeof(struct aperture), GFP_KERNEL);
> +	if (!a)
> +		return NULL;
>  	a->count = max_num;
>  	return a;
>  }
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux