Re: [PATCH] fb_defio: fix for non-dirty ptes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 13, 2010 at 4:51 AM, Albert Herranz <albert_herranz@xxxxxxxx> wrote:
> This patch fixes a problem observed while using fb_defio with a short
> delay on a PowerPC platform.
>
> It is possible that page_mkclean() is invoked in the deferred io work
> function _before_ a PTE has been marked dirty. In this case, the page
> is removed from the defio pagelist but page_mkclean() does not
> write-protect the page again. The end result is that defio ignores all
> subsequent writes to the page and the corresponding portions of the
> framebuffer never get updated.
>
> The fix consists in keeping track of the pages with non-dirty PTEs,
> re-checking them again on the next deferred io work iteration.
> Note that those pages are not passed to the defio callback as they are
> not written by userspace yet.
>
> Signed-off-by: Albert Herranz <albert_herranz@xxxxxxxx>

Looks good to me. Thanks for the bugfix.

Acked-by: Jaya Kumar <jayakumar.lkml@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux