On Thu, 29 Apr 2010 20:44:12 -0500
Timur Tabi <timur.tabi@xxxxxxxxx> wrote:
> On Thu, Apr 29, 2010 at 6:49 PM, Anatolij Gustschin <agust@xxxxxxx> wrote:
>
> > +Optional properties:
> > +- EDID : verbatim EDID data block describing attached display.
> > + Data from the detailed timing descriptor will be used to
> > + program the display controller.
>
> The property name should be lower-case.
Will change to lower-case.
> > /*
> > * These parameters give default parameters
> > @@ -217,6 +218,7 @@ struct mfb_info {
> > int x_aoi_d; /* aoi display x offset to physical screen */
> > int y_aoi_d; /* aoi display y offset to physical screen */
> > struct fsl_diu_data *parent;
> > + char *edid_data;
>
> edid_data should be "u8 *". "char *" is should be used only for
> strings or arrays of characters.
Will fix it, too.
> > + /* Still not found, use preferred mode from database if any */
> > + if (!has_default_mode && info->monspecs.modedb != NULL) {
>
> No need for the "!= NULL"
Ok, I will simplify this.
Thanks,
Anatolij
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
