> -----Original Message----- > From: James Simmons [mailto:jsimmons@xxxxxxxxxxxxx] > Sent: Wednesday, April 21, 2010 6:51 PM > To: Hiremath, Vaibhav > Cc: Andrew Morton; Grazvydas Ignotas; linux-fbdev@xxxxxxxxxxxxxxx > Subject: RE: [PATCH] fbdev: move FBIO_WAITFORVSYNC to linux/fb.h > > > > > -----Original Message----- > > > From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] > > > Sent: Wednesday, April 21, 2010 4:25 AM > > > To: Hiremath, Vaibhav > > > Cc: Grazvydas Ignotas; linux-fbdev@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH] fbdev: move FBIO_WAITFORVSYNC to linux/fb.h > > > > > > On Tue, 20 Apr 2010 14:35:10 +0530 > > > "Hiremath, Vaibhav" <hvaibhav@xxxxxx> wrote: > > > > > > > ... > > > > > > > > > --- a/include/linux/fb.h > > > > > +++ b/include/linux/fb.h > > > > > @@ -23,6 +23,8 @@ struct dentry; > > > > > #else > > > > > #define FBIO_CURSOR _IOWR('F', 0x08, struct fb_cursor) > > > > > #endif > > > > > +#define FBIO_WAITFORVSYNC _IOW('F', 0x20, __u32) > > > > > + > > > > [Hiremath, Vaibhav] Do not insert it in middle, lets follow the > sequence > > > and append it at last. Otherwise looks ok to me. > > > > > [Hiremath, Vaibhav] Andrew, > > If I understand correctly, the previous patch was not following the IOCTL > numbering sequence. > > > > Logically this IOCTL should get added as per their number sequence that is > at the end after FBIOGET_DISPINFO (0x4618). > > Changing the IOCTL number for WAITFORSYNC would break several apps like > egl and directfb. I'm afraid we are stuff with that number. [Hiremath, Vaibhav] Yeah, I understand this, and thinking on the same line, I am not asking to change the ioctl no, it's only placing the declaration/definition in logical sequence. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
