On Wed, Mar 31, 2010 at 20:43:29, Ambrose, Martin wrote: > Andrew, > > Thanks for the feedback. > > > > +/* > > > + * Function to wait for vertical sync which for this LCD peripheral > > > + * translates into waiting for the current raster frame to complete. > > > + */ > > > +static int fb_wait_for_vsync(struct fb_info *info) > > > +{ > > > + struct da8xx_fb_par *par = info->par; > > > + wait_queue_t wq; > > > + int ret; > > > + > > > + init_waitqueue_entry(&wq, current); > > > > DECLARE_WAITQUEUE() would be more conventional. > > I'll update -- cloned this from some older code I think. After looking at this further this variable wasn't even used so I will trim this in upcoming v3 patch. Regards, Martin -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html