Re: [PATCH v2 1/5] fbdev: section cleanup in arcfb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hendrik,

[added stable@xxxxxxxxxx to Cc: as
c2e13037e6794bd0d9de3f9ecabf5615f15c160b was requested to be added, too]

The whole series looks good
(aka. Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>).

On Fri, Apr 02, 2010 at 01:59:30PM +0200, Henrik Kretzschmar wrote:
> This patch fixes the sections in the arcfb driver, by moving:
> 
> *	the variables arcfb_fix and arcfb_var from .init.data to .devinit.data
> 
> *	arcfb_remove() from .text to .devexit.text

Maybe add: "This fixes the following warnings issued by modpost:" here?

Thanks
Uwe

> WARNING: drivers/video/built-in.o(.devinit.text+0x543): Section mismatch in reference from the function arcfb_probe() to the variable .init.data:arcfb_var
> The function __devinit arcfb_probe() references
> a variable __initdata arcfb_var.
> If arcfb_var is only used by arcfb_probe then
> annotate arcfb_var with a matching annotation.
> 
> WARNING: drivers/video/built-in.o(.devinit.text+0x558): Section mismatch in reference from the function arcfb_probe() to the variable .init.data:arcfb_fix
> The function __devinit arcfb_probe() references
> a variable __initdata arcfb_fix.
> If arcfb_fix is only used by arcfb_probe then
> annotate arcfb_fix with a matching annotation.

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux